Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two small typos #5251

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix two small typos #5251

merged 1 commit into from
Dec 6, 2024

Conversation

ryanlevy
Copy link
Contributor

@ryanlevy ryanlevy commented Dec 6, 2024

Proposed changes

I've encountered two small typos:

  • The CMake release variable was spelled QMCAPCK instead of QMCPACK
    • This doesn't seem to be set anywhere though
  • The hdf5 create ignores flags input
    • any created archive would be done with H5F_ACC_TRUNC mode only
    • There are only a few instances of the alternative H5F_ACC_EXCL being used
    AFQMC/Wavefunctions/WavefunctionFactory.cpp
    1191:        if (!restart.create(restart_file, H5F_ACC_EXCL))
    
    AFQMC/Walkers/tests/test_sharedwset.cpp
    252:  if (!dump.create("dummy_walkers.h5", H5F_ACC_EXCL))
    317:  if (!dump.create("dummy_walkers.h5", H5F_ACC_EXCL))
    458:    if (!dump.create("dummy_walkers.h5", H5F_ACC_EXCL))
    

What type(s) of changes does this code introduce?

  • Bugfix
  • Code style update (formatting, renaming)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

@ye-luo
Copy link
Contributor

ye-luo commented Dec 6, 2024

Test this please

@ye-luo ye-luo enabled auto-merge December 6, 2024 19:10
@prckent
Copy link
Contributor

prckent commented Dec 6, 2024

Thanks Ryan!

@ye-luo ye-luo merged commit 80a9b57 into QMCPACK:develop Dec 6, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants